Skip to content

Commit

Permalink
Update skip versions for flat_object tests (opensearch-project#15448)
Browse files Browse the repository at this point in the history
While fixing a flat_object bug, I noticed that we were skipping all
related yamlRestTests on pre-3.0 versions. Since the flat object field
type was added in 2.7, that should be the correct skip level for most
tests. The bug I fixed is still present in 2.16 and earlier, so the
test that covers that fix needs to be skipped pre-2.17.

Signed-off-by: Michael Froh <[email protected]>
  • Loading branch information
msfroh authored and dk2k committed Oct 21, 2024
1 parent 9e77040 commit eb8b1e1
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ teardown:
# and no dynamic fields were created.
"Mappings":
- skip:
version: " - 2.99.99"
reason: "flat_object is introduced in 3.0.0 in main branch"
version: " - 2.16.99"
reason: "flat_object field with null (doc 4) throws exception before 2.17"

- do:
indices.get_mapping:
Expand All @@ -131,8 +131,8 @@ teardown:
---
"Supported queries":
- skip:
version: " - 2.99.99"
reason: "flat_object is introduced in 3.0.0 in main branch"
version: " - 2.16.99"
reason: "flat_object field with null (doc 4) throws exception before 2.17"


# Verify Document Count
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ teardown:
# and no dynamic fields were created.
"Mappings":
- skip:
version: " - 2.99.99"
reason: "flat_object is introduced in 3.0.0 in main branch"
version: " - 2.6.99"
reason: "flat_object is introduced in 2.7"

- do:
indices.get_mapping:
Expand All @@ -106,8 +106,8 @@ teardown:
---
"Supported queries":
- skip:
version: " - 2.99.99"
reason: "flat_object is introduced in 3.0.0 in main branch"
version: " - 2.6.99"
reason: "flat_object is introduced in 2.7"


# Verify Document Count
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ teardown:
---
"Supported queries":
- skip:
version: " - 2.99.99"
reason: "flat_object is introduced in 3.0.0 in main branch"
version: " - 2.6.99"
reason: "flat_object is introduced in 2.7"

# Verify Document Count
- do:
Expand Down Expand Up @@ -607,8 +607,8 @@ teardown:
---
"Unsupported":
- skip:
version: " - 2.99.99"
reason: "flat_object is introduced in 3.0.0 in main branch"
version: " - 2.6.99"
reason: "flat_object is introduced in 2.7"

# Mapping parameters (such as index/search analyzers) are currently not supported
# The plan is to support them in the next version
Expand Down

0 comments on commit eb8b1e1

Please sign in to comment.