Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article draft added #117

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Article draft added #117

merged 1 commit into from
Jul 5, 2024

Conversation

vv-monsalve
Copy link
Contributor

@djrrb, @justvanrossum

At GF, we are enhancing the About section of the fonts to include images and more descriptive text about the fonts, their features and their advantages.

This PR introduces a preliminary version of the required 'ARTICLE.en_us.html' file for Bungee Tint, which we are about to onboard. However, this draft is intended to serve as a template for all other related font families, and the dedicated paragraph for each font will need to be customized to describe each case specifically.

You can find more information about the article file here and the necessary images here. Please review them and merge this draft, which can be used as a starting point for editing or complementing.

I've included a brief paragraph at the end acknowledging Marte and Just's work; please adjust it.

@djrrb djrrb merged commit 3da9048 into djrrb:master Jul 5, 2024
2 checks passed
@djrrb
Copy link
Owner

djrrb commented Jul 5, 2024

I’ve merged and will make a few edits. @justvanrossum feel free to edit as well.

@vv-monsalve
Copy link
Contributor Author

Hi @djrrb are you planning to include some images for the article? We are getting closer to the onboarding time, and it seems this piece is mostly the main one we'll need now :)

@djrrb
Copy link
Owner

djrrb commented Jul 10, 2024

@vv-monsalve I just added some images to documentation/article/ folder...is that correct?

Am I also supposed to include them using <img src="..." /> in the ARTICLE.en_us.html file? And if so, is there an example of that? (didn’t see it in the instructions)

djrrb added a commit that referenced this pull request Jul 10, 2024
@vv-monsalve
Copy link
Contributor Author

I just added some images to documentation/article/ folder...is that correct?

Perfect! Thanks

Am I also supposed to include them using in the ARTICLE.en_us.html file?

No, I'll add them and create a PR with the changes; there, you'll be able to decide on the order or any new additions.

The idea would be to update the About section of the non-colored fonts, too. Would you like to add a couple of images for them?

@djrrb
Copy link
Owner

djrrb commented Jul 10, 2024

No, I'll add them and create a PR with the changes; there, you'll be able to decide on the order or any new additions.

Thanks! FWIW my preferred order is reflected in the filenames but feel free to tweak as needed.

The idea would be to update the About section of the non-colored fonts, too. Would you like to add a couple of images for them?

Okay I’ve added a couple images that show the basic fonts with less color and fancy layering. Let me know if you’d like to see anything else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants