Update Indonesian localflavour

[geomars]

Modification:

• Update PROVINCE_CHOICES in localflavor/id_/id_choices.py to comply with official codes issued by Indonesian internal affair ministry
• Update test/test_id.py

[claudep]

Thanks, much better now! @benkonrath will probably review it in due time. But I don't think this will be accepted as is, because this would break existing usage for people having stored previous values in their models. I'm sure Ben will be able to help with coping with this sort of changes.

[codecov-io]

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   95.93%   95.93%           
=======================================
  Files         157      157           
  Lines        3981     3981           
  Branches      523      523           
=======================================
  Hits         3819     3819           
  Misses         98       98           
  Partials       64       64

Impacted Files	Coverage Δ
localflavor/id_/id_choices.py	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78df3b...4d17e58. Read the comment docs.

[geomars]

Thanks for your review @claudep

[benkonrath]

@geomars Thanks for this pull request and sorry for the delay in responding. Could you provide some background on why you want to change the codes that are stored for the provinces? Is it because the current codes aren't meaningful?

Instead of changing the current version of PROVINCE_CHOICES, I think it's better to make a new version with a different name. You would also need to create new version of IDProvinceSelect that uses the new version of PROVINCE_CHOICES. Doing this will allow us to depreciate the current versions, highlight this deprecation in the changelog and eventually remove the field and the choices.

[benkonrath]

I get a 404 page not found error when I try to load this URL. Has this page been removed since you made this pull request?