Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding US State Level localflavors #137

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

igorzelenberg
Copy link

Adding state level localflavors: adding New York State Counties first.

Added forms, models and test for New York State
Changed heading in ny.rst file
@igorzelenberg
Copy link
Author

Looking over Travis CI build errors.

@jezdez jezdez added this to the 1.2 milestone Dec 11, 2014
@igorzelenberg
Copy link
Author

Fixed the breaks (submitting new pull request)

@igorzelenberg igorzelenberg reopened this Dec 11, 2014
@benkonrath benkonrath removed this from the 1.2 milestone Nov 23, 2015
@ambsw-technology
Copy link

I actually found this issue when looking for any discussion on counties.

I can imagine a state-level field working for state governments and highly regulated industries like insurance, but not much else. That isn't to say it shouldn't be merged (in fact the county data can be leveraged in a more widely-used model), but doesn't make a strong case for it either.

I suspect most people need a national county field that cross-filters on state. At minimum, some kind of back-end validation could be added, but a useful field would really require some form magic. I have a feeling that kind of functionality is out-of-scope for this package so it's probably a lost cause (though I too want/need it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants