Fix task cancellation propagation to subtasks when using sync middleware #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttys0dev
force-pushed
the
fix-cancel-task
branch
12 times, most recently
from
732cd5a
to
f2563b1
Compare
ttys0dev
changed the title
ttys0dev
force-pushed
the
fix-cancel-task
branch
5 times, most recently
from
7cce2c8
to
953cf67
Compare
ttys0dev
force-pushed
the
fix-cancel-task
branch
from
953cf67
to
6f29943
Compare
|
Looks pretty good to me - I'll see how it meshes with #439 as well to make sure that everything is reasonable before I cut a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #434.