Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AbstractOrder.return_order #187

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

radekholy24
Copy link
Contributor

Symmetrically to AbstractOrder.complete_order, we want to return an order and reduce the account.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 86.73%. Comparing base (f27b38d) to head (318e260).
Report is 3 commits behind head on master.

Files Patch % Lines
plans/base/models.py 87.50% 3 Missing ⚠️
plans/admin.py 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   86.79%   86.73%   -0.06%     
==========================================
  Files          64       64              
  Lines        2347     2375      +28     
==========================================
+ Hits         2037     2060      +23     
- Misses        310      315       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PetrDlouhy PetrDlouhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, only correct those few changes.

CHANGELOG Outdated
@@ -1,6 +1,10 @@
django-plans changelog
======================

1.1.0 (unreleased)
------------------
* Add `AbstractOrder.return_order`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AbstractOrder.return_order() to be clear that it is a function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@@ -47,6 +47,7 @@ Contributors:
* Victor Safronovich <[email protected]>
* Dominik Kozaczko <http://dominik.kozaczko.info>
* Petr Dlouhý <[email protected]>
* Blender Kit <[email protected]>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BlenderKit <[email protected]> and/or give yourself a credit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@@ -13,6 +13,7 @@
framework.

"""

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unnecessary modification of this file.

Copy link
Contributor Author

@radekholy24 radekholy24 Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think so too, but it won't pass Black otherwise... 🤦
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@PetrDlouhy PetrDlouhy merged commit 4742b76 into django-getpaid:master Apr 5, 2024
25 checks passed
@radekholy24 radekholy24 deleted the return_order branch April 5, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants