feat: add exit_code label to execution_done_count
#1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `exit_code` label adds useful information to the `execution_done_count` metric. The exit codes are usually `0`, `1` or `127`, this is a low cardinality metric. This label will allow us use promQL to perform standard operations like calculate the number of failed vs total jobs.
|
Fixes #1570 |
vcastellm
previously approved these changes
Sep 10, 2024
atmosx
force-pushed
the
panagiotis/update-metrics
branch
from
5eb5675
to
5f2db9b
Compare
|
@vcastellm sorry, made a mistake and pushed two commits to this repo. These were meant for another repo to get a working version of the metric with the new label, dropped the additional commits and force-pushed. |
vcastellm
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
exit_codelabel adds useful information to theexecution_done_countmetric. The exit codes are usually0,1or127, this is a low cardinality metric.This label will allow us use promQL to perform standard operations like calculate the number of failed vs total jobs.