fix: include own weight in threshold checks in update_state

distributed-lab · Sep 10, 2024 · 9807e83 · 9807e83
1 parent c1a689e
commit 9807e83
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/party.rs b/src/party.rs
@@ -474,7 +474,8 @@ impl<V: Value, VS: ValueSelector<V>> Party<V, VS> {
                     self.messages_1b_weight +=
                         self.cfg.party_weights[routing.sender as usize] as u128;
 
-                    if self.messages_1b_weight >= self.cfg.threshold {
+                    let self_weight = self.cfg.party_weights[self.id as usize] as u128;
+                    if self.messages_1b_weight >= self.cfg.threshold - self_weight {
                         self.status = PartyStatus::Passed1b;
                     }
                 }
@@ -554,7 +555,8 @@ impl<V: Value, VS: ValueSelector<V>> Party<V, VS> {
                         self.cfg.party_weights[routing.sender as usize] as u128,
                     );
 
-                    if self.messages_2av_state.get_weight() >= self.cfg.threshold {
+                    let self_weight = self.cfg.party_weights[self.id as usize] as u128;
+                    if self.messages_2av_state.get_weight() >= self.cfg.threshold - self_weight {
                         self.status = PartyStatus::Passed2av;
                     }
                 }
@@ -586,7 +588,8 @@ impl<V: Value, VS: ValueSelector<V>> Party<V, VS> {
                         self.cfg.party_weights[routing.sender as usize] as u128,
                     );
 
-                    if self.messages_2b_state.get_weight() >= self.cfg.threshold {
+                    let self_weight = self.cfg.party_weights[self.id as usize] as u128;
+                    if self.messages_2b_state.get_weight() >= self.cfg.threshold - self_weight {
                         self.status = PartyStatus::Passed2b;
                     }
                 }
@@ -1143,7 +1146,7 @@ pub(crate) mod tests {
 
     #[tokio::test]
     async fn test_ballot_faulty_party() {
-        let cfg = BPConConfig::with_default_timeouts(vec![1, 1, 1, 1], 2);
+        let cfg = BPConConfig::with_default_timeouts(vec![1, 1, 1, 1], 3);
 
         let (mut parties, mut channels) = create_parties(cfg);