Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graffiti/crayon bug fix + new graffiti #8237

Closed
wants to merge 1 commit into from
Closed

graffiti/crayon bug fix + new graffiti #8237

wants to merge 1 commit into from

Conversation

Twomoon-Github
Copy link
Contributor

@Twomoon-Github Twomoon-Github commented Jul 17, 2023

About The Pull Request

Fix the bug where if you dont interact with the menu, move, then interact you would draw when away from the target (fixed it for spraycan, and for the crayons, still need a fix for the crafting station)

Adds: one excelsior graffiti, a technomancer graffiti, a neotheo graffiti

and also adds other factions graffiti (moebius, IH, aster) made by KIROV

Why It's Good For The Game

Fix a bug. Adds the faction graffiti, that i got asked for since i worked on the graffiti

Testing

all clear

i tried to remake like the bug, and it no longer start making a graffiti, it also tells you your too far away.

Changelog

🆑 Twomoon, KIROV
fix: fix the remote interaction bug for graffiiti and spray cans
imageadd: added more graffitis
code: added a few lines in the graffiti files + the crayons.dm
/:cl:

@Twomoon-Github
Copy link
Contributor Author

i wanted to make the graffiti behave like poster in this PR too (where if you paint it south of the wall, you cant see it if your at the north of the wall) but idk yet how, so i prefer to fix the bug first, adds the new graffiti, then i will try working on it (if i do it i will make sure it can only be done on walls too)

@Firefox13
Copy link
Contributor

Testing description is not for "It works" but for "I did X and Y and it works"
Credit people properly in changelog (it explains how). You don't need to list every single line added, just general changes.

@Firefox13
Copy link
Contributor

Re-read the changelog guide, it says to put namesnin-front of first :cl:, I did that for you.
Everything else is probably ok.

@Humonitarian
Copy link
Contributor

Make sure to include a picture of them working ingame too, ideally showcasing all new graffiti

This will also be useful for the devblog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants