Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds graffiti + spraypaint #8232

Merged
merged 21 commits into from
Jul 14, 2023
Merged

Adds graffiti + spraypaint #8232

merged 21 commits into from
Jul 14, 2023

Conversation

Twomoon-Github
Copy link
Contributor

@Twomoon-Github Twomoon-Github commented Jul 11, 2023

About The Pull Request

Adds graffiti made by Cringelord and a spraypaint to make said graffitis on turfs.
the spraypaint item can be printed in the aster misc disk for about the same mats as the floor painter.
To use: simply click on a turf (wall, floors) with the spraypaint, a popup will appear to pick which graffiti you want to make.
have 30 uses

to cancel a graffiti, simply move out, or you can clean them up with a soap or any cleaning items. graffitis can be stacked, and will appear uner the wall objects like buttons so we can use them without problems.

Why It's Good For The Game

Adds new decoration/Adds flavor (graffiti are eris themes), more may come later like faction logo graffiti, or roach graffitis (better to not add too much of them, but around 10 is a good amounts for lot of variety)

graffiti_eris

Testing

PR has been tested many times, no error, everything is working.

Changelog

🆑
add: added spraypaint + graffitis
soundadd: added a graffiti.ogg + graffity_empty.ogg
imageadd: added spraypaint in items.dmi + wall_graffiti.dmi
code: added spraypaint.dm/changed cleanable/misc.dm/asters.dm and devices.dm to add the spraypaint to the disk
/:cl:

@Twomoon-Github
Copy link
Contributor Author

Twomoon-Github commented Jul 11, 2023

for the -1 line, i didnt deleted anything, its just weird how it considered the line gone when the line is still here: hpart_case, in aster.dm, so overall no problem

@Firefox13
Copy link
Contributor

Where did you get the sound?

code/game/objects/items/spraypaint.dm Outdated Show resolved Hide resolved
code/game/objects/items/spraypaint.dm Outdated Show resolved Hide resolved
code/datums/autolathe/devices.dm Outdated Show resolved Hide resolved
code/game/objects/items/spraypaint.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/design_disks/asters.dm Outdated Show resolved Hide resolved
code/game/objects/items/spraypaint.dm Outdated Show resolved Hide resolved
code/game/objects/items/spraypaint.dm Outdated Show resolved Hide resolved
code/game/objects/items/spraypaint.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Firefox13 Firefox13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good

code/game/objects/items/spraypaint.dm Outdated Show resolved Hide resolved
code/game/objects/items/spraypaint.dm Outdated Show resolved Hide resolved
Twomoon-Github and others added 3 commits July 12, 2023 15:50
ah yes, havent got to my mind this goes on the ear lol

Co-authored-by: Firefox13 <[email protected]>
Copy link
Contributor

@hyperioo hyperioo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use span macros for to_chat

Like
to_chat(user, SPAN_NOTICE("You start tagging \the [target.name]!"))
instead of
to_chat(user, "<span class='notice'>You start tagging \the [target.name]!</span>")

@hyperioo hyperioo merged commit 5cab49e into discordia-space:master Jul 14, 2023
5 of 6 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants