Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointerException in ButtonImpl#toData #2770

Closed
wants to merge 1 commit into from
Closed

Fix NullPointerException in ButtonImpl#toData #2770

wants to merge 1 commit into from

Conversation

Xirado
Copy link
Contributor

@Xirado Xirado commented Nov 10, 2024

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Fixes a regression introduced in #2752 where the label in ButtonImpl#toData() is incorrectly checked if empty when null

@MinnDevelopment
Copy link
Member

Please:

  • Change the factory method to pass in "" instead of null in addition to this change
  • Add a regression test for this

@Xirado Xirado closed this Nov 10, 2024
@Xirado Xirado deleted the fix/button-label-null-check branch November 10, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xirado @MinnDevelopment