Replace instant by web-time #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Jun 24, 2024
src/counters/timer.rs
Outdated
| @@ -54,7 +55,7 @@ impl Timer { | |||
| /// Resume the timer. | |||
| pub fn resume(&mut self) { | |||
| if self.enabled { | |||
| self.start = Some(instant::now()); | |||
| self.start = Some(Instant::now().elapsed().as_secs_f64()); | |||
There was a problem hiding this comment.
I'm not sure if there's a less verbose way to get that.
|
Why make this change? |
|
Short answer is that instant is no longer maintained and makes web target difficult to compile. |
sebcrozet
requested changes
Sep 6, 2024
src/counters/timer.rs
Outdated
| @@ -54,7 +55,7 @@ impl Timer { | |||
| /// Resume the timer. | |||
| pub fn resume(&mut self) { | |||
| if self.enabled { | |||
| self.start = Some(instant::now()); | |||
| self.start = Some(Instant::now().elapsed().as_secs_f64()); | |||
There was a problem hiding this comment.
Suggested change
| self.start = Some(Instant::now().elapsed().as_secs_f64()); | |
| self.start = Some(Instant::now()); |
| @@ -57,7 +58,7 @@ impl HarnessPlugin for FluidsHarnessPlugin { | |||
| } | |||
|
|
|||
| fn step(&mut self, physics: &mut PhysicsState, _run_state: &RunState) { | |||
| let step_time = instant::now(); | |||
| let step_time = Instant::now().elapsed().as_secs_f64(); | |||
There was a problem hiding this comment.
Suggested change
| let step_time = Instant::now().elapsed().as_secs_f64(); | |
| let step_time = Instant::now(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: I'll want a changelog line once #54 is merged
To be noted instant is still used somewhere in the dependencies, mostly optionally and through rapier_testbed
Details