Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOV: add abgabe page #1214

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ZOV: add abgabe page #1214

wants to merge 5 commits into from

Conversation

pgurusinga
Copy link
Member

No description provided.

@@ -3,6 +3,7 @@ import type { AllContextKeys } from "~/flows/common";
import type { Flow } from "~/flows/flows.server";
import type { ArrayConfig } from "~/services/array";
import type { FlowTransitionConfig } from "~/services/session.server/flowTransitionValidation.server";
import abgabeFlow from "./abgabe/flow.json";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vscode suggested this lol

Copy link
Contributor

@aaschlote aaschlote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, maybe we need to change the URL as defined the ticket

"id": "abgabe",
"initial": "start",
"states": {
"start": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the url without the start? It's defined in the ticket the url should be /fluggastrechte/formular/abgabe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. We also have zusammenfassung/start, which I guess doesn't make sense since it doesn't start a process in the subflow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's ask Kirstin about this.

@@ -0,0 +1,11 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want, you can move this flow.json to the app/flows/fluggastrechteFormular/index.ts, so it would be something:

abgabe: {
        id: "abgabe",
        meta: { done: () => false },
        "on": {
         "BACK": "#zusammenfassung.start"
         }
        },

Copy link

sonarcloud bot commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants