-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOV: add abgabe page #1214
base: main
Are you sure you want to change the base?
ZOV: add abgabe page #1214
Conversation
@@ -3,6 +3,7 @@ import type { AllContextKeys } from "~/flows/common"; | |||
import type { Flow } from "~/flows/flows.server"; | |||
import type { ArrayConfig } from "~/services/array"; | |||
import type { FlowTransitionConfig } from "~/services/session.server/flowTransitionValidation.server"; | |||
import abgabeFlow from "./abgabe/flow.json"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vscode suggested this lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, maybe we need to change the URL as defined the ticket
"id": "abgabe", | ||
"initial": "start", | ||
"states": { | ||
"start": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make the url without the start
? It's defined in the ticket the url should be /fluggastrechte/formular/abgabe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. We also have zusammenfassung/start
, which I guess doesn't make sense since it doesn't start a process in the subflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's ask Kirstin about this.
@@ -0,0 +1,11 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want, you can move this flow.json to the app/flows/fluggastrechteFormular/index.ts
, so it would be something:
abgabe: {
id: "abgabe",
meta: { done: () => false },
"on": {
"BACK": "#zusammenfassung.start"
}
},
Quality Gate passedIssues Measures |
No description provided.