-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2918: Add tts on web #2985
Draft
bahaaTuffaha
wants to merge
17
commits into
main
Choose a base branch
from
2918-Add-TTS-on-web
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
2918: Add tts on web #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d unnecessary mock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Adding text-to-speech functionality for web.
Proposed changes
TtsPlayer.tsx
will receive content and title fromuseTtsPlayer.ts
hook then it will process content as following:<p>
or<li>
tag if there is non at the end.sentencex
to support most languages.TtsPlayer.tsx
using EasySpeech library for web speech api .. why I used it instead of directly using the native api read here: https://github.com/leaonline/easy-speech/blob/master/FAQ.md#why-does-this-library-exists-if-i-can-use-tts-natively-in-the-browserWeb Speech API has some limitation on devices like Android I can't pause so I implemented a way to increment
currentSentencesIndex
at each sentence so pausing will be depend on sentence index . Another issue with Firefox about triggering onEnd function at any.cancel()
method unlike chromium based browsers (added useeffect to check whether it reached the last index or not ... Note : sometimes content gets finished reading before reaching end of the array)This is different from tts-native: voices needs to be installed from OS so a modal will show up
TtsHelpModal
to guide users for each platform. Note: by default for windows for example you have what the keyboard layout have of languages also it may need a restart to see the newly installed language.Modified Modal.tsx to accept new props: icon and styling just for (backgroundColor, borderRadius)
Notes:
Side effects
Testing
Resolved issues
Fixes: #2918