Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2577: Add warning color #2971

Merged
merged 4 commits into from
Nov 11, 2024
Merged

2577: Add warning color #2971

merged 4 commits into from
Nov 11, 2024

Conversation

simomps
Copy link
Contributor

@simomps simomps commented Oct 24, 2024

Short description

Add warningColor to project

Proposed changes

  • Add variable warningColor (#FFA726)
  • Use warningColor in Feedback warning message instead of themeColor (#FBDA16)

Side effects

None.

Testing

Check that all settings still work.

Resolved issues

Fixes: #2577


Copy link

codeclimate bot commented Oct 24, 2024

Code Climate has analyzed commit 6c54b13 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 74.2%.

View more on Code Climate.

@simomps simomps changed the title 2577 add warning color 2577: Add warning color Oct 24, 2024
Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Perfect! Now we just need more warnings to display 😄 Tested on firefox.

I found one more place where this color should be used (native):

background-color: ${props => props.theme.colors.themeColor};

Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, looks good. 💪 🚀

Tested on Firefox.

@simomps simomps merged commit c4538c1 into main Nov 11, 2024
9 checks passed
@simomps simomps deleted the 2577-add-warning-color branch November 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use warning color for notes
3 participants