-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2577: Add warning color #2971
2577: Add warning color #2971
Conversation
Code Climate has analyzed commit 6c54b13 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 74.2%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Perfect! Now we just need more warnings to display 😄 Tested on firefox.
I found one more place where this color should be used (native):
background-color: ${props => props.theme.colors.themeColor}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, looks good. 💪 🚀
Tested on Firefox.
Short description
Add warningColor to project
Proposed changes
Side effects
None.
Testing
Check that all settings still work.
Resolved issues
Fixes: #2577