-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1609: Enable store import koblenz #1655
Conversation
78b2915
to
8161337
Compare
…g on the buildConfig, fix test
8161337
to
fa8902f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Please add an example csv of the store upload to /administration/resources/stores
-
Tested and is not working, when using the csv from nextcloud i get this error: Die erforderlichen Spalten sind nicht vorhanden oder nicht in der richtigen Reihenfolge.
Whenever you are sharing a nextcloud link it only opens the landing page for me. I do not have this problem when others are sharing links, i think the correct nextcloud link is:
https://nextcloud.tuerantuer.org/index.php/apps/files/files/6518906?dir=/Projects/Digitale%20Berechtigungskarte/Stadt%20Koblenz/Akzeptanzpartner&openfile=true
Not sure what you are sharing, but it seems not to work.
administration/src/bp-modules/stores/__tests__/AcceptanceStoreEntry.test.ts
Outdated
Show resolved
Hide resolved
administration/src/bp-modules/stores/__tests__/AcceptanceStoreEntry.test.ts
Outdated
Show resolved
Hide resolved
administration/src/bp-modules/stores/__tests__/StoresButtonBar.test.tsx
Outdated
Show resolved
Hide resolved
administration/src/bp-modules/stores/__tests__/StoresButtonBar.test.tsx
Outdated
Show resolved
Hide resolved
I have no clue why its not working for you. Bildschirmaufnahme.2024-10-03.um.12.35.51.movI added a sample file to the repository since i don't want to upload the real csv from koblenz |
Tested again, works as expected 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on firefox, works as expected
can you please recheck and give me an approve if its fine @ztefanie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The columns width is not really good. I do not like the hard coded widths, there are nice approaches to handle this dynamically, see here: palantir/blueprint#1863 (comment)
If entering chars (not numbers) or nothing for lat/long i get the wrong error message "Keine passenden Geodaten gefunden! Bitte prüfen sie die Adresse." If the lat/long is invalid, it should either show a message with the info lat/long is wrong or directly get it, if adress is valid.
Special chars should not be allowed in categoryId section, i can input there "10%" and get no error in the ui, but a 500 is thrown when clicking "import stores"
postalcode should only allow numbers
i did not check every field, but the field definitively need checks
Thanks for testing!
|
… error if coordinates are invalid values
…ort-koblenz # Conflicts: # administration/src/project-configs/bayern/config.ts # administration/src/project-configs/getProjectConfig.ts # administration/src/project-configs/koblenz/config.ts # administration/src/project-configs/nuernberg/config.ts # administration/src/project-configs/showcase/config.ts # administration/src/util/getBuildConfig.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really happy with only a frontend check, but as this is an endpoint only for logged in users, I think it is oke, but still bad practice.
there is an open issue for that and this functionality will not be served to end users for now. So everything is addressed |
…ort-koblenz # Conflicts: # administration/src/bp-modules/stores/StoresCSVInput.tsx # administration/src/bp-modules/stores/StoresImportController.tsx # administration/src/bp-modules/stores/__tests__/StoresCSVInput.test.tsx # administration/src/project-configs/helper/storeFieldValidation.ts
Short description
As a store maintainer i want to upload the csv stores for koblenz
Proposed changes
Side effects
Testing
Find correct store file here: https://nextcloud.tuerantuer.org/index.php/apps/files/files/6468170
But you can also use same test files as for nuernberg
Resolved issues
Fixes: #1609