Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerifierPlus does not recognize new issuers in any registry #52

Closed
bmuramatsu opened this issue Mar 15, 2023 · 7 comments
Closed

VerifierPlus does not recognize new issuers in any registry #52

bmuramatsu opened this issue Mar 15, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@bmuramatsu
Copy link
Collaborator

Issuer DIDs are hardcoded into VerifierPlus.

https://github.com/digitalcredentials/web-verifier-plus/blob/main/data/issuerDid.ts

If a new issuer is added to one of the DCC registries, VerifierPlus does not recognize the did.

@bmuramatsu bmuramatsu added the bug Something isn't working label Mar 15, 2023
@bmuramatsu
Copy link
Collaborator Author

Suggested approaches

  1. For SJCC, add SJCC's issuer did into https://github.com/digitalcredentials/web-verifier-plus/blob/main/data/issuerDid.ts, redeploy and test on Vercel, if it works redeploy and test on verifierplus.org
  2. -or- we could refactor VerifierPlus to hardcode all of DCC's registries, or determine a registry of registries file that it reads in either on each verification or at specified intervals and cache.
    (There are four options presented here all registries, read in at verification; registry of registries, read in at verfication; all registries, read in at specified intervals and cache; registry of registries, read in at specified intervals and cache.) And then redeploy and test on Vercel, if it works redeploy and test on verifierplus.org.

@bmuramatsu
Copy link
Collaborator Author

bmuramatsu commented Mar 15, 2023

Test Credentials:

{
  "@context": [
    "https://www.w3.org/2018/credentials/v1",
    "https://purl.imsglobal.org/spec/ob/v3p0/context.json",
    "https://w3id.org/security/suites/ed25519-2020/v1"
  ],
  "id": "urn:uuid:2a28c227-ebc6-4dab-9226-d3c541149057",
  "type": [
    "VerifiableCredential",
    "OpenBadgeCredential"
  ],
  "name": "Emerging Tech Entrepreneurship Level 1",
  "issuer": {
    "type": "Profile",
    "id": "did:key:z6MkpcJENgsDNoVct5MnzM49sydB35GvewXEdJeWdy68yi4j",
    "name": "San José City College",
    "url": "https://www.sjcc.edu",
    "image": {
      "id": "https://www.eslstation.net/wp-content/uploads/2020/05/sjcc-square.jpg",
      "type": "Image"
    }
  },
  "issuanceDate": "2020-05-22T00:00:00.000+00:00",
  "credentialSubject": {
    "type": [
      "AchievementSubject"
    ],
    "id": "did:key:z6Mkus9Gw6paSW638N1Qmv1Tc9L7cZJSQ7qF37KWjbmYN6q4",
    "name": "SJCC Jaguar",
    "achievement": {
      "id": "urn:uuid:24c58959-4549-405b-a4de-fb341ce94c95",
      "type": [
        "Achievement"
      ],
      "name": "Emerging Tech Entrepreneurship Level 1",
      "description": "Pilot digital credential for SJCC's Emerging Tech Entrepreneurship Level 1.",
      "criteria": {
        "narrative": "Students who complete the Emerging Tech Entrepreneurship certificates will be exposed to and become proficient in the coursework to become entrepreneurs in a technical field. This program combines the business skills necessary to make sound business decisions with the technical know-how to survive in the 21st century. Students will learn how to build and manage successful modern technical businesses."
      }
    }
  },
  "expirationDate": "2024-01-01T00:00:00.000+00:00",
  "proof": {
    "type": "Ed25519Signature2020",
    "created": "2023-03-15T14:44:32Z",
    "verificationMethod": "did:key:z6MkpcJENgsDNoVct5MnzM49sydB35GvewXEdJeWdy68yi4j#z6MkpcJENgsDNoVct5MnzM49sydB35GvewXEdJeWdy68yi4j",
    "proofPurpose": "assertionMethod",
    "proofValue": "z2oBzoV62Ft7h1Wcsyebw8jCSQX19wc8YJR6XxK8Bi7z6LTZs5H48afb4k3sq5MvLUMaYr9LMv1U2JsZQXWBA3ypX"
  }
}

@jchartrand
Copy link
Contributor

I've submitted a PR that adds the SJCC did to the local WV+ registry (if we opt to go that way temporarily):

#54

I don't think I can deploy it to Vercel though - I don't think I have permissions.

@bmuramatsu
Copy link
Collaborator Author

Registry contents are hard coded into VerifierPlus, remove to point to registries themselves.

@kayaelle
Copy link
Member

kayaelle commented Aug 9, 2023

Related to digitalcredentials/verifier#3

This was referenced Aug 16, 2023
@kayaelle
Copy link
Member

Moving to ready for review.

@alexfigtree alexfigtree added this to the 0.1.1 milestone Feb 21, 2024
@alexfigtree alexfigtree removed this from the 0.1.1 milestone Mar 25, 2024
@alexfigtree
Copy link
Member

Prioritizing #141 over this ticket, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done (Deployed)
Development

No branches or pull requests

8 participants