Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VerifierPlus does not report if a did is not found in a registry #53

Closed
bmuramatsu opened this issue Mar 15, 2023 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@bmuramatsu
Copy link
Collaborator

if (!registries.issuerDid.isInRegistry(issuerDid)) {
throw new Error(CredentialErrorTypes.DidNotInRegistry);

  if (!registries.issuerDid.isInRegistry(issuerDid)) {
    throw new Error(CredentialErrorTypes.DidNotInRegistry);
  }

Instead of showing an error the UI is stuck at "Verifying..."

@bmuramatsu bmuramatsu added the bug Something isn't working label Mar 15, 2023
@bmuramatsu
Copy link
Collaborator Author

@jchartrand tracked this down while researching #52

@lautom36 lautom36 self-assigned this Aug 21, 2023
@lautom36
Copy link
Contributor

This issue is resolved with the fix from #52

@kayaelle kayaelle closed this as completed Sep 6, 2023
@kayaelle kayaelle reopened this Sep 6, 2023
@kayaelle
Copy link
Member

kayaelle commented Sep 11, 2023

@lautom36 ignore the comment that was here. Misread your comment above about #52

@kayaelle
Copy link
Member

Going to close this because we are changing how we search the registries related to issue: #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants