-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project general update #64
Conversation
Still looking this over, but my initial impression is that there are a lot of loosely related changes here that would arguably have been better as smaller, more focused PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately the only blocking change is that pipeline typo, the rest are simply suggestions
This is quite involved, you've made good ground on splitting the actions apart & updating the docs 👍🏼
One thing worth considering for future is the usage of black
& moving away from the flake8 rules, as the code styles for this project are alien compared to most modern python projects (which will be using black)
This Pull Request updates the OpenFisca Core dependancy to the latest version of OpenFisca Core. It also simplifies the project environment to leverage pyproject.toml (without reliance on poetry). The overall goal is to modernise the project from a python project perspective and improve the documentation.
These changes :