Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project general update #64

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Project general update #64

merged 9 commits into from
Aug 19, 2024

Conversation

verbman
Copy link
Contributor

@verbman verbman commented Jun 3, 2024

This Pull Request updates the OpenFisca Core dependancy to the latest version of OpenFisca Core. It also simplifies the project environment to leverage pyproject.toml (without reliance on poetry). The overall goal is to modernise the project from a python project perspective and improve the documentation.

  • Technical improvement.
  • Details:
    • Updated Documentation
    • Updated OpenFisca Core dependancy (to latest)
    • Updated python environment and version (3.11)
    • Updated docker related files
    • Updated github related files

These changes :

  • Impact the OpenFisca-Aotearoa public API (latest version via OpenFisca core)
  • Change non-functional parts of this repository

.yamllint Show resolved Hide resolved
@jadedarko
Copy link
Contributor

Still looking this over, but my initial impression is that there are a lot of loosely related changes here that would arguably have been better as smaller, more focused PRs

CONTRIBUTING.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/devcontainer.md Outdated Show resolved Hide resolved
docs/pyenv.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jadedarko jadedarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately the only blocking change is that pipeline typo, the rest are simply suggestions

This is quite involved, you've made good ground on splitting the actions apart & updating the docs 👍🏼

One thing worth considering for future is the usage of black & moving away from the flake8 rules, as the code styles for this project are alien compared to most modern python projects (which will be using black)

@verbman verbman merged commit 404806a into main Aug 19, 2024
5 checks passed
@verbman verbman deleted the env-update branch August 19, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants