-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch GCC-12 CI job to GCC 13 #7841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
features/gcc-13
branch
2 times, most recently
from
August 9, 2023 08:29
47ee2ef
to
463b6f5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7841 +/- ##
===========================================
- Coverage 78.80% 78.54% -0.27%
===========================================
Files 1699 1699
Lines 195104 195107 +3
===========================================
- Hits 153756 153246 -510
- Misses 41348 41861 +513
☔ View full report in Codecov by Sentry. |
tautschnig
force-pushed
the
features/gcc-13
branch
5 times, most recently
from
August 10, 2023 09:01
afbb754
to
d855255
Compare
GCC 13 no longer implicitly drags in stdint as an include. This is a fix-up to bdd42d3, which introduced the need for stdint types.
We previously issued a similar fix in 90d9c7a. GCC 13 now reports this in another two files, fixed in this commit.
This is treated the same as _Float16, matching the specification at https://gitlab.com/x86-psABIs/x86-64-ABI/-/blob/master/x86-64-ABI/low-level-sys-info.tex (section "Special Types"). This type is required for/tested by regression test SIMD1 when using GCC 13.
Make optAttribute conditionally call rAttribute (and rename the latter to rGCCAttribute).
tautschnig
force-pushed
the
features/gcc-13
branch
from
August 14, 2023 10:22
d855255
to
2b47568
Compare
We would previously only accept `inline constexpr`, but not the swapped order of keywords.
tautschnig
force-pushed
the
features/gcc-13
branch
from
August 14, 2023 14:05
2b47568
to
9585fa7
Compare
GCC built-in to implement std::is_constant_evaluated. We just provide a declaration, but no implementation at this point.
This is to test an even more recent GCC release. Also, disable doc and package building attempts as those are already covered in other CI jobs.
tautschnig
force-pushed
the
features/gcc-13
branch
from
August 14, 2023 16:03
9585fa7
to
8b95e24
Compare
tautschnig
requested review from
a team,
kroening,
peterschrammel and
remi-delmas-3000
as code owners
August 14, 2023 16:53
Please review commit-by-commit. |
NlightNFotis
approved these changes
Aug 15, 2023
kroening
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to test an even more recent GCC release.