Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GCC-12 CI job to GCC 13 #7841

Merged
merged 7 commits into from
Aug 23, 2023
Merged

Conversation

tautschnig
Copy link
Collaborator

This is to test an even more recent GCC release.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added the CI label Aug 9, 2023
@tautschnig tautschnig self-assigned this Aug 9, 2023
@tautschnig tautschnig force-pushed the features/gcc-13 branch 2 times, most recently from 47ee2ef to 463b6f5 Compare August 9, 2023 08:29
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 81.25% and project coverage change: -0.27% ⚠️

Comparison is base (08a466d) 78.80% compared to head (9585fa7) 78.54%.

❗ Current head 9585fa7 differs from pull request most recent head 8b95e24. Consider uploading reports for the commit 8b95e24 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7841      +/-   ##
===========================================
- Coverage    78.80%   78.54%   -0.27%     
===========================================
  Files         1699     1699              
  Lines       195104   195107       +3     
===========================================
- Hits        153756   153246     -510     
- Misses       41348    41861     +513     
Files Changed Coverage Δ
src/goto-cc/ms_cl_cmdline.h 0.00% <ø> (ø)
src/goto-cc/ms_link_cmdline.h 0.00% <ø> (ø)
src/goto-programs/elf_reader.cpp 61.25% <ø> (ø)
src/ansi-c/scanner.l 63.50% <25.00%> (-0.22%) ⬇️
src/cpp/parse.cpp 69.17% <100.00%> (+0.08%) ⬆️

... and 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the features/gcc-13 branch 5 times, most recently from afbb754 to d855255 Compare August 10, 2023 09:01
GCC 13 no longer implicitly drags in stdint as an include. This is a
fix-up to bdd42d3, which introduced the need for stdint types.
We previously issued a similar fix in 90d9c7a. GCC 13 now reports this
in another two files, fixed in this commit.
This is treated the same as _Float16, matching the specification at
https://gitlab.com/x86-psABIs/x86-64-ABI/-/blob/master/x86-64-ABI/low-level-sys-info.tex
(section "Special Types").

This type is required for/tested by regression test SIMD1 when using GCC
13.
Make optAttribute conditionally call rAttribute (and rename the latter
to rGCCAttribute).
We would previously only accept `inline constexpr`, but not the swapped
order of keywords.
GCC built-in to implement std::is_constant_evaluated. We just provide a
declaration, but no implementation at this point.
This is to test an even more recent GCC release. Also, disable doc and
package building attempts as those are already covered in other CI jobs.
@tautschnig
Copy link
Collaborator Author

Please review commit-by-commit.

@tautschnig tautschnig merged commit d61bffc into diffblue:develop Aug 23, 2023
34 of 35 checks passed
@tautschnig tautschnig deleted the features/gcc-13 branch August 23, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants