Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and some changes to the base structure #64

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Conversation

alkidbaci
Copy link
Collaborator

Refactoring

  • Created package owlapy.abstracts with 3 modules:

    • abstract_owl_ontology_manager.py
    • abstract_owl_ontology.py
    • abstract_owl_reasoner.py
  • Abstract classes OWLOntologyManager and OWLOntologyChange moved from owlapy.owl_ontology_manager to owlapy.abstracts.abstract_owl_ontology_manager

  • Abstract class OWLOntology moved from owlapy.owl_ontology to owlapy.abstracts.abstract_owl_ontology.

  • Abstract classes OWLReasoner and OWLReasonerEx modev from owlapy.owl_reasoner to owlapy.abstracts.abstract_owl_reasoner

Changes

  • Signature changes on methods of OWLReasoner:

    • The argument only_named is no longer a required argument of the abstract methods
    • The argument direct is no longer required on the following methods: data_property_values, object_property_values and all_data_property_values.
  • The current reasoners have not changed. Reasoners such as FastInstanceCheckerReasoner still uses the above mentioned arguments, where they have a default value, but SyncReasoner for example does not.

  • Class SyncReasoner now inherit from OWLReasoner.

  • Added Structural reasoner as an option to SyncReasoner.

@alkidbaci alkidbaci merged commit 007563b into develop Sep 10, 2024
5 checks passed
@alkidbaci alkidbaci deleted the base_changes branch September 10, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant