Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: metall compat with boost >= 1.85 #20

Closed
wants to merge 2 commits into from

Conversation

liss-h
Copy link
Collaborator

@liss-h liss-h commented Oct 2, 2024

Fix compat with recent boost releases.

Issue

Previously construct_n had an additional out parameter that told you how many elements were successfully constructed, this is no longer the case.

Compare the impl in this with the original boost impl:
https://github.com/boostorg/interprocess/blob/a0c5a8ff176434c9024d4540ce092a2eebb8c5c3/include/boost/interprocess/detail/segment_manager_helper.hpp#L211-L224

@liss-h
Copy link
Collaborator Author

liss-h commented Oct 2, 2024

Since the issue explained in the PR description is present, it does not feel safe to actually include this.

I will close this PR, we'll just have to use an older boost version.

@liss-h liss-h closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant