Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: compatibility with older metall versions #18

Merged
merged 10 commits into from
Sep 18, 2024
Merged

Fix: compatibility with older metall versions #18

merged 10 commits into from
Sep 18, 2024

Conversation

liss-h
Copy link
Collaborator

@liss-h liss-h commented Sep 17, 2024 •
edited
Loading

Conditionally include the logger header to provide compat with older metall versions.
This is needed if dependents of this package want to override the metall version

bigerl
bigerl requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. I have a small remark and a suggestions.

src/dice/ffi/metall_internal.hpp Show resolved Hide resolved
src/dice/ffi/metall_internal.hpp Show resolved Hide resolved
@liss-h liss-h requested a review from bigerl September 18, 2024 12:08
@liss-h liss-h merged commit 46d172e into develop Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigerl bigerl bigerl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liss-h @bigerl