Fixes 124 Adding missing attribute #125
Conversation
tclaus
force-pushed
the
bugfix/124/add_thread_parent_guid_to_comment
branch
from
c723573
to
b6dd7ca
Compare
There was a problem hiding this comment.
As already mentioned in #124 (comment), this isn't in the library yet intentionally, because adding it would require explicit handling on the diaspora side. So unless you also want to add support and handling for it on the diaspora side (which will be a lot more work than just adding the field here, since it also requires a migration of existing data from friendica), I wouldn't recommend to add this yet. Because if this gets merged we wouldn't be able to upgrade the lib anymore for diaspora until it's properly handled there.
Also sidenote: A more useful commit message would be appreciated where a short "what was done" is in the first line, and a fixes #124 in an additional line so GitHub actually detects that and auto-closes the issue when it gets merged. Currently it's kinda the other way around, but without the # GitHub doesn't even detect the issue.
| # A random string of at least 16 chars pointing to a parent comment. | ||
| # @see Validation::Rule::Guid | ||
| # @return [String] parent comment guid | ||
| property :thread_parent_guid, :string, optional: true |
There was a problem hiding this comment.
The field should also be added to the CommentValidator to validate it's a valid GUID.
And it should also be added to the comment entity in lib/diaspora_federation/schemas/federation_entities.json.
Adds the thread_parent_guid_ attribute to comment as described in the docs.