-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Create supporters page #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty nice! Where do you plan to place a link to this page? In the footer?
app/views/pages/supporters.html.erb
Outdated
</div> | ||
</div> | ||
|
||
<div class="page-header"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be in the container, it feels weird to see it taking the whole page width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
Sure, why not! Not too sure, however, if we still should include Pivotal and Kickstarter. Those days are over and sometimes, you have to get rid of old stories. |
@goobertron do you still want to work on that? I now have my dev install working again so I can review your work once you fixed the above remarks ;) Btw, should we include bountysource there? They are featuring us on their home. Not sure if that counts as "supporter". |
Hi, thanks for prompting me. I had hit another problem with running the dev environment, but I've just tried bundle again and this time it compiled and is working once again (hurrah!). I've placed the strapline inside the container as requested, but there's little more I can do until we've decided what content to include there. At the moment it's just a basic layout with a few supporters (GitHub, Travis, Let's Ecrypt and WebTranslateIt) listed, with a brief description I wrote for each. I'll push the tiny change with the strapline code moved, anyway. |
Yes, I like it. But I agree with @denschub, I would only include organizations which are currently supporting us or which we are using. But maybe we could add bountysource instead? Also, since you mentioned "people and organizations" we could maybe combine it with the contributors page from #108, after we decided which people to list there? |
Sure; as I said, this WIP so far is only about concept and layout; I just slung in a few things as 'dummy' entries to show how it would look. We need to discuss what content we include and don't include. I would like to put forward the suggestion, however, to have a separate section underneath the supporters: 'We would also like to thank the following people and organizations that helped Diaspora in its earlier days' as a way of keeping acknowledgement of previous support without suggesting that they are still actively supporting diaspora*. We could definitely include contributors on the same page; they certainly support the project, with time and effort rather than money. And we could mention other types of supporters, such as podmins, although not individually by name. Let's open a separate issue for a contributors page, as we clearly have a lot to discuss about what form that would take. |
So if people can give their suggestions for which supporters should be included on this page, I can then move the PR forward. Edit: oh, and please, if you can, add a brief explanation of their support so I can add that, as sometimes I won't know what they do for the project. Currently, among active supporters, we have just GitHub, Travis, WebTranslateIt and SFLC. I'm not sure I'd consider Bountysource as a supporter; we pay them for using their platform as they take a 10% cut of any donation. That's not what I consider support. |
OK, was just an idea :) But I have another one we should add to the list: JetBrains for providing RubyMine licenses. |
Sure, and we need ideas so we can make decisions! Fla had also suggested Bountysource so I thought I'd give my view now.
Nice, thanks. |
On reflection, I think it would be good to integrate a contributors section on this page, and to create the whole page via templates and a database. That second part is something I might be able to do in PHP, but couldn't do in Ruby – at least not without quite a bit of help. Is the code used to do this in the original project site likely to be any help as a starting point? I linked to some of the relevant files on the If I'm not going to be able to do this, someone else could pick up the commits in this PR and complete the work. |
I don't know if the old code still works, but I think we can help you with the code. When you just do the page with static dummy content, it will be easy in the end to replace it with the content from the database. |
This PR got automatically closed by GitHub after we deleted the |
Will fix #49 when completed.
@denschub @SuperTux88 @svbergerem @Flaburgan am I going in the right direction with this? Layout, content, etc.
Let's discuss that before I go any further.