Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpdriver: dont set http.Client timeout to a default value #448

Merged
merged 1 commit into from
Sep 16, 2024
Merged

httpdriver: dont set http.Client timeout to a default value #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions utils/httputil/httpdriver/default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"io"
"net/http"
"net/url"
"time"
)

// DefaultClient implements Client and wraps around the stdlib Client.
Expand All @@ -19,12 +18,9 @@ func WrapClient(client http.Client) Client {
return DefaultClient(client)
}

// NewClient creates a new client around the standard library's http.Client. The
// client will have a timeout of 10 seconds.
// NewClient creates a new client around the standard library's http.Client.
func NewClient() Client {
return WrapClient(http.Client{
Timeout: 10 * time.Second,
})
return WrapClient(http.Client{})
}

func (d DefaultClient) NewRequest(ctx context.Context, method, url string) (Request, error) {
Expand Down
Loading