Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”§ Fixes regression introduced in ollama engine #404

Conversation

unconstructive
Copy link
Contributor

It looks like #391 refactoring broke ollama, using opencommit 3.1.1 with OCO_AI_PROVIDER=ollama will fail to connect displaying the following error:

β”Œ  opencommit
β”‚
β—‹  Generating commit message
β”‚
β””  βœ– Error: Ollama provider error: Invalid URL

@di-sukharev di-sukharev merged commit 9ad281a into di-sukharev:dev Sep 2, 2024
3 checks passed
@di-sukharev
Copy link
Owner

3.1.2 is out, run npm i -g opencommit@latest

@di-sukharev
Copy link
Owner

thank you for fixing it

@unconstructive
Copy link
Contributor Author

No problem! Thank you for the quick response πŸ‘
Confirmed ollama is working now

@domci
Copy link

domci commented Sep 3, 2024

Thanks for working on this. Sadly I still get

β”Œ  opencommit
β”‚
β—‹  Generating commit message
β”‚
β””  βœ– Error: Ollama provider error: Invalid URL
oco --version
3.1.2

Maybe something else is amiss?

@di-sukharev
Copy link
Owner

di-sukharev commented Sep 3, 2024 via email

@domci
Copy link

domci commented Sep 4, 2024

OCO_EMOJI=true
OCO_LANGUAGE=en
OCO_MESSAGE_TEMPLATE_PLACEHOLDER=$msg
OCO_AI_PROVIDER=ollama
OCO_OPENAI_API_KEY=sk-foo

@0xnestyan
Copy link

image

same here. I used ollama and mistral model.
here is my config:

OCO_MODEL=mistral
OCO_AI_PROVIDER=ollama
OCO_TOKENS_MAX_INPUT=40960
OCO_TOKENS_MAX_OUTPUT=4096
OCO_DESCRIPTION=false
OCO_EMOJI=true
OCO_LANGUAGE=en
OCO_MESSAGE_TEMPLATE_PLACEHOLDER=$msg
OCO_PROMPT_MODULE=conventional-commit
OCO_ONE_LINE_COMMIT=false
OCO_TEST_MOCK_TYPE=commit-message
OCO_GITPUSH=true
OCO_WHY=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants