[yang]Fixing sonic-cfg-help to handle nested container #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing sonic-cfg-help to handle nested container scenario. In case of nested container, the inner container name acts as key for the table. For e.g.
"AUTO_TECHSUPPORT": {
"GLOBAL": {
}
}
vivekrnv
reviewed
Nov 22, 2023
| self.print_field_desc(table.get('container'), field) | ||
| elif isinstance(table['container'], list): | ||
| for c in table['container']: | ||
| print("key - " + c.get('@name')) |
There was a problem hiding this comment.
Can we filter the common logic b/w these two, i.e. handling a single container dictinto a separate function and re-use in both the cases?
There was a problem hiding this comment.
print_field_desc is purpose is to do that - print a container. In the list case we loop through the list and call this API. The only additional line is printing the key. I prefer to keep this outside of print_field_desc function and so you had one line of duplication.
vivekrnv
approved these changes
Nov 22, 2023
dgsudharsan
pushed a commit
that referenced
this pull request
Dec 11, 2023
…utomatically (sonic-net#17229) #### Why I did it src/sonic-host-services ``` * 689395a - (HEAD -> 202305, origin/202305) Updated the iptable rule to use parent/base name of midplane interface of chassis. (#75) (2 days ago) [abdosi] * 45212a8 - [DualToR][caclmgrd] Fix IPtables rules for multiple vlan interfaces for DualToR config (#82) (2 days ago) [vdahiya12] ``` #### How I did it #### How to verify it #### Description for the changelog
dgsudharsan
pushed a commit
that referenced
this pull request
Mar 27, 2024
…e latest HEAD automatically (sonic-net#18374) #### Why I did it src/wpasupplicant/sonic-wpa-supplicant ``` * 13e6f1100 - (HEAD -> master, origin/master, origin/HEAD) Fix a memory leak introduced by last commit for high level EVP API #82 (64 minutes ago) [xumia] |\ | failure_prs.log 225157a01 - Merge branch 'master' into master (3 days ago) [wumiao_nokia] | |\ | |/ |/| * | 413704a6c - Provide CMAC high level API replacement #81 (4 days ago) [xumia] | failure_prs.log c7eafc778 - Fix a memory leak introduced by last commit for high level EVP API for CMAC (3 days ago) [wumiao_nokia] |/ * 8521d4abb - Fix a port issue (6 days ago) [wumiao_nokia] * 01a39044a - Provide CMAC high level API replacement (6 days ago) [wumiao_nokia] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixing sonic-cfg-help to handle nested container scenario. In case of nested container, the inner container name acts as key for the table. For e.g.
Work item tracking
How I did it
Fixing sonic-cfg-help tool to handle nested container
How to verify it
Added UT to verify it.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)