feat: show diagnostics on multiline diags #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a diagnostic spans multiple lines, the current implementation doesn't show anything past the first line. This changes this behavior.
This is set as the default, but happy to but that behind a flag if needed.
The one case that is problematic (even now) is if
end_col
doesn't exist (as it seems it can be, same forend_lnum
) then the last checkdiag.col <= col and (diag.end_col or diag.col) >= col)
will only be true on the actualcol
and nowhere else since(diag.col <= col and diag.col >= col)
is equivalent to the two being equal. I don't know how often this happens in practice. This is why I've kept the old behavior if we don't havediag.end_col and diag.end_lnum
, though personally I would show it for the whole line if we don't have aend_col
.