Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window pos #49

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Window pos #49

wants to merge 6 commits into from

Conversation

Stateford
Copy link
Contributor

Implemented #36. Saves window position when minimized and when the window is closing.

@Stateford
Copy link
Contributor Author

@dfs-minded Hello! Why was this assigned to me? Is there something that must be changed?

dfs-minded
dfs-minded reviewed Oct 16, 2019
View reviewed changes
IndexerGUI/UserSettings.cs Outdated Show resolved Hide resolved
IndexerGUI/MainWindow.xaml.cs Outdated Show resolved Hide resolved
@dfs-minded
Copy link
Owner

dfs-minded commented Oct 16, 2019 via email

@Stateford
Copy link
Contributor Author

I tried making changes on a new computer and I seem to be running into some build issues.

When I build for "Any CPU" it causes a runtime error caused by mismatched process architecture.

System.BadImageFormatException: 'Could not load file or assembly 'CLIInterop, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. An attempt was made to load a program with an incorrect format.'

When I build for x86 as suggested, it causes a bunch of warnings about "std::wstring" not being part of the std library (the string header is never included).

Here are a few of the errors

1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(21): error C2039: 'wstring': is not a member of 'std'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std'
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(21): error C2061: syntax error: identifier 'wstring'
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2039: 'wstring': is not a member of 'std'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std'
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2065: 'wstring': undeclared identifier
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2923: 'std::vector': 'wstring' is not a valid template type argument for parameter '_Ty'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(352): error C3203: 'allocator': unspecialized class template can't be used as a template argument for template parameter '_Alloc', expected a real type
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C3203: 'vector': unspecialized class template can't be used as a template argument for template parameter '_Ty', expected a real type
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(33): error C2039: 'wstring': is not a member of 'std'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std'
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(33): error C2065: 'wstring': undeclared identifier

@dfs-minded
Copy link
Owner

dfs-minded commented Oct 21, 2019 via email

@Stateford
Copy link
Contributor Author

@dfs-minded
Hello,
I have found the one missing library but I still run into an error:

1>c:\users\japos\source\repos\indexer-plus-plus\indexertest\indexmanagertest.cpp(58): error C2039: 'CheckUpdates': is not a member of 'indexer::IndexManager'
1>c:\users\japos\source\repos\indexer-plus-plus\searchengine\indexmanager.h(33): note: see declaration of 'indexer::IndexManager'
1>c:\users\japos\source\repos\indexer-plus-plus\indexertest\indexmanagertest.cpp(62): error C2039: 'CheckUpdates': is not a member of 'indexer::IndexManager'
1>c:\users\japos\source\repos\indexer-plus-plus\searchengine\indexmanager.h(33): note: see declaration of 'indexer::IndexManager'

when I look at the code I see this:

#ifdef SINGLE_THREAD
        void CheckUpdates();
#endif

This flag looks like it's not enabled in the preprocessor.

@Stateford
Copy link
Contributor Author

Looks like it could build in release and not debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfs-minded dfs-minded dfs-minded left review comments

Assignees

@Stateford Stateford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stateford @dfs-minded