Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): use jsonReplacer to stringify bigints #3569

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix(frontend): use jsonReplacer to stringify bigints #3569

merged 1 commit into from
Nov 14, 2024

Conversation

DenysKarmazynDFINITY
Copy link
Contributor

Motivation

The PR fixes one of the issues reported in #3480. Also, I noticed a few more places where the same kinda of error could have appeared.

@DenysKarmazynDFINITY DenysKarmazynDFINITY requested a review from a team as a code owner November 14, 2024 17:02
AntonioVentilii
AntonioVentilii approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix and the catch!

P.S. maybe at some point we should extract it as separate function

@DenysKarmazynDFINITY
Copy link
Contributor Author

@AntonioVentilii definitely, a util something like safeJsonStringify would be useful for this kind of cases.

@DenysKarmazynDFINITY DenysKarmazynDFINITY merged commit 6d62bff into main Nov 14, 2024
14 checks passed
@DenysKarmazynDFINITY DenysKarmazynDFINITY deleted the fix(frontend)/json-stringify-bigint branch November 14, 2024 18:04
peterpeterparker
peterpeterparker reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker left review comments

@AntonioVentilii AntonioVentilii AntonioVentilii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DenysKarmazynDFINITY @peterpeterparker @AntonioVentilii