POC: Bitcoin transaction with modal and new signer endpoint #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2024
lmuntaner
added a commit
that referenced
this pull request
Sep 26, 2024
# Motivation The component displaying the network name wasn't taking into account regtest. # Changes * Add a condition to check testnet instead of falling back to testnet if not mainnet. # Tests Works locally in #2528
|
Feature deployed and working on staging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a proof of concept to write the whole functionality of sending bitcoins from Oisy.
This helps confirm that the functionality doesn't have a blocker before breaking it down into smaller PRs as well as understanding what small pieces are needed and how to break them.
Changes
Tests