Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(frontend): expand space available for main title #2089

Merged
merged 4 commits into from
Aug 21, 2024
Merged

style(frontend): expand space available for main title #2089

merged 4 commits into from
Aug 21, 2024

Conversation

AntonioVentilii-DFINITY
Copy link
Contributor

Motivation

As per request, we expand the main title to occupy the available space.

Before

Screenshot 2024-08-21 at 14 47 53

After

Screenshot 2024-08-21 at 14 47 44

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY requested a review from a team as a code owner August 21, 2024 12:48
@DenysKarmazynDFINITY
Copy link
Contributor

DenysKarmazynDFINITY commented Aug 21, 2024 •
edited
Loading

@AntonioVentilii-DFINITY just a friendly reminder to run https://github.com/dfinity/oisy-wallet/actions/workflows/update-snapshots.yml against your branch to update the snapshots. I also just noticed that we launch e2e-tests check only when the files in e2e folder have been updated. This behaviour is something to be changed as we are getting more and more test suites, I'll take care of it.

@peterpeterparker
Copy link
Member

How does it looks like on really large screen, like a single line? Shouldn't we set a max-width to occupy two lines?

@AntonioVentilii-DFINITY
Copy link
Contributor Author

It is already limited by one of the parents:

Screenshot 2024-08-21 at 17 44 04

peterpeterparker
peterpeterparker approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@AntonioVentilii-DFINITY
Copy link
Contributor Author

@DenysKarmazynDFINITY thank you for the heads-up! I will run the workflow on this branch, but I am pretty sure that other PRs (already merged) have affected the test...

I agree, it should set up in a sort of automatic way

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit ddaa5c7 into main Aug 21, 2024
10 of 11 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the style(frontend)/expand-space-for-main-title branch August 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

@anedos-dfinity anedos-dfinity Awaiting requested review from anedos-dfinity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonioVentilii-DFINITY @DenysKarmazynDFINITY @peterpeterparker @AntonioVentilii