Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: reimplement M0200 for #4580 #4584

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

crusso
Copy link
Contributor

@crusso crusso commented Jun 28, 2024

Builds on #4580.

Moves M0200 error detection from compile.ml to typing.ml, using special #deprecation M0200 in Prim.ml (the same trick we use to selectively deprecate stable memory prims).

@crusso crusso changed the title experiment: reimplement M0200 for # experiment: reimplement M0200 for #4580 Jun 28, 2024
@crusso crusso changed the base branch from master to ryan/component-call June 28, 2024 10:45
Copy link

Comparing from 0d36eff to 2125101:
In terms of gas, 1 tests regressed and the mean change is +0.6%.
In terms of size, no changes are observed in 5 tests.

Copy link
Contributor

@rvanasa rvanasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@rvanasa rvanasa marked this pull request as ready for review June 28, 2024 17:17
@rvanasa rvanasa merged commit d18df6d into ryan/component-call Jun 28, 2024
8 checks passed
@rvanasa rvanasa deleted the claudio/component-call branch June 28, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants