Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) File/package/canister remove/rename on hover #87

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

taylorham
Copy link
Contributor

@taylorham taylorham commented Oct 19, 2021

Redo of #84 to keep work on this remote URL for easier collaboration.

Screen Shot 2021-10-19 at 11 59 22 AM
Screen Shot 2021-10-04 at 10 09 29 PM
Screen Shot 2021-10-04 at 10 09 49 PM

Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LG. Will also wait for dfinity/motoko#2846 to get a proper deletion feature on the virtual file system.

Can you also add deletion to the package and canister section? Deletion can hover on the canister section as well. This way we can also fix the alignment problem when canister has no time-out.

@@ -28,6 +28,10 @@
"build": {
"output": "build",
"packtool": "vessel sources"
},
"start": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'll hardcode the port in the install script instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I tried to remove this, and can deploy and run test just fine?

@@ -0,0 +1,16 @@
#!/bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it outside the src directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, does that mean you want this script at root?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

under /script/ would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants