-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) File/package/canister remove/rename on hover #87
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # src/components/Explorer.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LG. Will also wait for dfinity/motoko#2846 to get a proper deletion feature on the virtual file system.
Can you also add deletion to the package and canister section? Deletion can hover on the canister section as well. This way we can also fix the alignment problem when canister has no time-out.
@@ -28,6 +28,10 @@ | |||
"build": { | |||
"output": "build", | |||
"packtool": "vessel sources" | |||
}, | |||
"start": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I'll hardcode the port in the install script instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I tried to remove this, and can deploy and run test just fine?
@@ -0,0 +1,16 @@ | |||
#!/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move it outside the src
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, does that mean you want this script at root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
under /script/ would be fine.
Redo of #84 to keep work on this remote URL for easier collaboration.