More refactoring for Vite migration #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-playground into ryan/migrate-vite
rvanasa
commented
Sep 4, 2024
| const scriptContent = await response.text(); | ||
| export const loadMoc = async () => { | ||
| if (!mocPromise) { | ||
| mocPromise = (async () => { |
There was a problem hiding this comment.
Replaced the global Motoko with mocPromise so that this logic only runs once if loadMoc() is called multiple times before this resolves.
chenyan-dfinity
added a commit
that referenced
this pull request
Sep 5, 2024
* checkpoint * checkpoint * handle moc * worker * fix * simplify vite.config * Refactoring for Vite migration (#249) * Misc * Remove extraneous config * simplify vite.config and bump versions * bump dependencies * fix * fix * remove eval in didToJs * fmt * Update hash for dfx version 0.23.0 * More refactoring for Vite migration (#252) * Reintroduce 'global' for dev server * Refactor to use 'Motoko' promise instead of global variable * Misc * Only run 'eval()' in 'loadMoc()' at most once * Reformat * chunking * fix * rename --------- Co-authored-by: Ryan Vandersmith <[email protected]> Co-authored-by: krpeacock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into #248.
Motokovariableglobaldefinition in Vite config to fix compilation error in dev server (unrelated to the above change)