Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for Vite migration #249

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Sep 4, 2024

Various changes to merge into #248:

  • Enables dfx output_env_file to fix missing environment variables in dev server.
  • Converts the project to use ES Modules, since CommonJS is deprecated in Vite.
  • Simplifies the prettier-plugin-motoko import.

@chenyan-dfinity chenyan-dfinity merged commit 102642f into migrate-vite Sep 4, 2024
2 checks passed
@chenyan-dfinity chenyan-dfinity deleted the ryan/migrate-vite branch September 4, 2024 00:53
chenyan-dfinity added a commit that referenced this pull request Sep 5, 2024
* checkpoint

* checkpoint

* handle moc

* worker

* fix

* simplify vite.config

* Refactoring for Vite migration (#249)

* Misc

* Remove extraneous config

* simplify vite.config and bump versions

* bump dependencies

* fix

* fix

* remove eval in didToJs

* fmt

* Update hash for dfx version 0.23.0

* More refactoring for Vite migration (#252)

* Reintroduce 'global' for dev server

* Refactor to use 'Motoko' promise instead of global variable

* Misc

* Only run 'eval()' in 'loadMoc()' at most once

* Reformat

* chunking

* fix

* rename

---------

Co-authored-by: Ryan Vandersmith <[email protected]>
Co-authored-by: krpeacock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants