Fetch readme #208
Closed
Fetch readme #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanasa
reviewed
Oct 20, 2023
| async function fetchCode() { | ||
| const files = await worker.fetchGithub({ repo, branch, dir }); | ||
| let files = await worker.fetchGithub({ repo, branch, dir }); | ||
| const readme = await (await fetch(readmeUrl)).text(); |
There was a problem hiding this comment.
This seems to have unexpected behavior when README.md doesn't exist at the root of the repository. I opened another PR (#209) which implements this feature using a slightly different approach to account for this situation.
|
Closed in favor of #209, and deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an upcoming workshop, I'd like to be able to fetch README files from the GitHub repository. This is currently only supported for some "Examples Projects" but not for "Import from GitHub". This PR supports fetching a README file at the root of the repository.