Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andri/last used #2683

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Andri/last used #2683

wants to merge 13 commits into from

Conversation

LXIF
Copy link
Contributor

@LXIF LXIF commented Nov 1, 2024

Add well-formatted and tested last usage date for each authentication device. This was already PR-ed, this new commit is a fix for the showcase screenshots. last_used is undefined on page load, so it doesn't yet have a length, so querying its length throws an error which broke the showcase. Fixed it by using optional chaining in the if clause in question.

Screenshot 2024-11-01 at 15 28 58
🟡 Some screens were changed

@LXIF LXIF requested a review from a team as a code owner November 1, 2024 14:32
@LXIF LXIF requested a review from lmuntaner November 1, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants