refactor(nns): Move cast_vote_and_cascade_follow into Governance struct #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
changed the title
max-dfinity
changed the base branch from
master
to
msum/stable-neuron-support-C
max-dfinity
force-pushed
the
msum/stable-neuron-support-D
branch
from
e44a16d
to
abe92bd
Compare
max-dfinity
force-pushed
the
msum/stable-neuron-support-D
branch
3 times, most recently
from
706b99e
to
eb25d69
Compare
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
2 times, most recently
from
2cb808a
to
886676d
Compare
max-dfinity
force-pushed
the
msum/stable-neuron-support-D
branch
from
eb25d69
to
1a56916
Compare
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
from
886676d
to
9828e39
Compare
max-dfinity
force-pushed
the
msum/stable-neuron-support-D
branch
from
1a56916
to
73b8fa1
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
This refactoring creates a state machine to handle voting, which will create natural break points in the ongoing calculations that are being done. This will allow us to scale voting with following to an arbitrarily large number of neurons. [Next](#2600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts cast_vote_and_cascade_follow into governance, which will be necessary for the next step of making it async, and then finally adding break points to increase the voting capacity.
Prev | Next