feat(ckbtc): Use the new KYT canister in ckbtc withdrawal flow #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninegua
force-pushed
the
paulliu/new-kyt-in-ckbtc-withdrawal
branch
6 times, most recently
from
cf0acd1
to
5741961
Compare
ninegua
added
the
CI_OVERRIDE_DIDC_CHECK
ninegua
force-pushed
the
paulliu/new-kyt-in-ckbtc-withdrawal
branch
10 times, most recently
from
a5c43b2
to
48fa8a6
Compare
ninegua
force-pushed
the
paulliu/regtest-network-kyt
branch
from
c71aa38
to
a2ea489
Compare
ninegua
force-pushed
the
paulliu/new-kyt-in-ckbtc-withdrawal
branch
from
48fa8a6
to
2742762
Compare
ninegua
force-pushed
the
paulliu/regtest-network-kyt
branch
from
a2ea489
to
1d97015
Compare
ninegua
force-pushed
the
paulliu/new-kyt-in-ckbtc-withdrawal
branch
from
8dba269
to
c0302d0
Compare
ninegua
force-pushed
the
paulliu/new-kyt-in-ckbtc-withdrawal
branch
from
27b6316
to
8362c92
Compare
ninegua
removed
the
CI_OVERRIDE_DIDC_CHECK
THLO
reviewed
Nov 4, 2024
THLO
reviewed
Nov 4, 2024
THLO
reviewed
Nov 4, 2024
THLO
reviewed
Nov 4, 2024
gregorydemay
reviewed
Nov 5, 2024
gregorydemay
reviewed
Nov 5, 2024
ninegua
added
the
CI_OVERRIDE_DIDC_CHECK
nmattia
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Thanks @ninegua for the improvements! Code LGTM, one last comment is regarding RetrieveBtcOfacFailed. Maybe I'm missing something, but I have the impression we don't need it at all.
gregorydemay
approved these changes
Nov 12, 2024
THLO
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new KYT canister as a dependency of the ckBTC minter, and use it instead of the old KYT canister for address checking during ckBTC -> BTC withdrawal.
Because the check_address call does not require payment, calling retrieve_btc on the ckBTC miner will no longer charge a KYT fee.