refactor: [MR-603] Typed canister queues and references #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eadlineExpired and ResponseDropped.
…ed-inbound-responses
…ed-inbound-responses
…lbacks_with_enqueued_response invariant in CanisterQueues doc comment.
…ed-inbound-responses
…ry reject response that will result in a critical eror anyway (and the response being dropped).
… as a dummy canister ID.
Assign type parameters to canister queues and references, to designate them as either input/inbound or output/outbound. Ensures that input queues can only hold inbound references; and output queues can only hold outbound references. Implements separate logic (for inbound and outbound references) for determining staleness, lookup and removal.
alin-at-dfinity
requested review from
stiegerc,
derlerd-dfinity and
oggy-dfin
Base automatically changed from
alin/MR-603-shed-inbound-responses
to
master
September 26, 2024 15:39
… the two specific `MessageStore<_>` implementations into `MessageStoreImpl`.
…nt when decoding CanisterQueue from proto.
…(but still CanisterInput by value for input queues).
derlerd-dfinity
approved these changes
Sep 30, 2024
…d to InboundReference / OutboundReference, to make it clear that the functions may panic (even though the two types are essentially private to the module).
oggy-dfin
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Thanks for making this more robust. I did a first pass over the "meat", though not the tests yet. I wonder:
- can we make the context the property of the
Ttype inReference<T>. That would seem to get rid of a bunch ofassertsthat we currently have - do we even need
Reference::contextto be visible from outside of message_pool? I.e., outside ofTryFrom<QueueItem>?
…e item types declare their own context (inbound vs outbound) and use that when constructing a new reference of the given type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MR-603: Assign type parameters to canister queues and references, to designate them as either input/inbound or output/outbound.
Ensures that input queues can only hold inbound references; and output queues can only hold outbound references. Implements separate logic (for inbound and outbound references) for determining staleness, lookup and removal.