fix: better error handling in components #1642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR:Issue-verification-failed
Elessar1802
added
PR:Ready-to-Review
Elessar1802
changed the title
Elessar1802
changed the title
Elessar1802
commented
Feb 22, 2024
src/components/ApplicationGroup/Details/TriggerView/EnvTriggerView.tsx
Outdated
Show resolved
Hide resolved
eshankvaish
requested changes
Feb 22, 2024
Elessar1802
force-pushed
the
sentry-fixes-amrit
branch
from
4f28c6b
to
831179f
Compare
Elessar1802
force-pushed
the
sentry-fixes-amrit
branch
from
62bf157
to
bc4e2c4
Compare
Elessar1802
changed the title
Elessar1802
commented
Feb 27, 2024
| @@ -1112,32 +1112,6 @@ export const reloadToastBody = () => { | |||
| ) | |||
| } | |||
|
|
|||
| export function useHeightObserver(callback): [RefObject<HTMLDivElement>] { | |||
There was a problem hiding this comment.
The contents of the custom hook seem a little convoluted and unnecessary to me. Since this is (was) being used only in TerminalView, I have refactored it out. React warns us from using useLayoutEffect anyways. The motive was probably that the actually resizing should be differed to the next repaint to prevent infinite loops in ResizeObserver callback. We shouldn't change the div size inside the resizeObserver. Thus using window.requestAnimationFrame will defer the actual resize until the next repaint saving us from the infinite resize.
Elessar1802
commented
Feb 27, 2024
src/components/ApplicationGroup/Details/TriggerView/EnvTriggerView.tsx
Outdated
Show resolved
Hide resolved
src/components/EnvironmentOverride/DeploymentTemplateOverrideForm.tsx
Outdated
Show resolved
Hide resolved
src/components/deploymentConfig/DeploymentTemplateView/DeploymentConfigFormCTA.tsx
Outdated
Show resolved
Hide resolved
Elessar1802
commented
Feb 27, 2024
| @@ -518,7 +518,7 @@ export default function DeploymentConfig({ | |||
| const deploymentTemplateResp = isProtected | |||
| ? await checkForProtectedLockedChanges() | |||
| : await getIfLockedConfigNonProtected(requestBody) | |||
| if (deploymentTemplateResp.result.isLockConfigError) { | |||
| if (deploymentTemplateResp.result?.isLockConfigError) { | |||
| setDisableSaveEligibleChanges(deploymentTemplateResp.result?.disableSaveEligibleChanges) | |||
There was a problem hiding this comment.
@vivek-devtron Do I need to remove these optional chaining checks on line 552 and 553?
Elessar1802
commented
Feb 27, 2024
| @@ -566,7 +566,7 @@ export default function DeploymentConfig({ | |||
| const requestBody = prepareDataToSave(true) | |||
| const api = state.chartConfig.id ? updateDeploymentTemplate : saveDeploymentTemplate | |||
| const deploymentTemplateResp = await api(requestBody, baseDeploymentAbortController.signal) | |||
| if (deploymentTemplateResp.result.isLockConfigError) { | |||
| if (deploymentTemplateResp.result?.isLockConfigError) { | |||
| setDisableSaveEligibleChanges(deploymentTemplateResp.result?.disableSaveEligibleChanges) | |||
Elessar1802
force-pushed
the
sentry-fixes-amrit
branch
from
6fcb9e6
to
f330de6
Compare
modified EnvTriggerView.tsx & TriggerView.tsx
Changes in appDetails/AppDetails.tsx, details/main.tsx & appDetails/AppDetails.component.tsx
Modifications in login/Login.tsx
| @@ -216,6 +216,7 @@ export default function EnvTriggerView({ filteredAppIds, isVirtualEnv }: AppGrou | |||
| setDefaultConfig(_isDefaultConfig) | |||
| setConfigPresent(isConfigPresent) | |||
| }) | |||
| .catch() | |||
edit renderSideInfoColumn in EnvironmentOverview.tsx
Elessar1802
force-pushed
the
sentry-fixes-amrit
branch
from
06a1e93
to
3a5939f
Compare
edit in deploymentConfig/DeploymentConfig.tsx
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An optional check is required since upon failure of the preceding api calls can return response objects without the result property field. (See fetchInTime & put) in devtron-fe-common-lib.
Added some missing catch blocks to api calls that can throw errors.
Fixed
ResizeObserver loop finished with undelivered notificationserror encountered upon resizing the window when the appDetails terminal is in view. Additionally refactored the code.Future Work:
Fixes devtron-labs/devtron#4710
Type of change
How Has This Been Tested?
Checklist: