Ttg device support master coro - util/device.h #5

therault · 2023-03-08T19:52:26Z

Add util/device.h and a ttg::device namespace to expose the C-like allocator, and a few util functions.

Signed-off-by: Joseph Schuchart <[email protected]>

# Conflicts: # examples/CMakeLists.txt

(cherry picked from commit 8147ac0)

Signed-off-by: Joseph Schuchart <[email protected]>

The views on the device will be handled by the backend, not in ttg::make_view Signed-off-by: Joseph Schuchart <[email protected]>

[ttg|std]::span is not a good fit because it carries a size template argument that we don't care about but makes handling more difficult. Plus, we need to encode the scope for each span. Three scopes are available: 1) SyncIn: copy host data to device before invoking the kernel callable. 2) SyncOut: copy the device data back to the host before invoking the output callable. 3) Allocate: allocate but do not synchronize in or out. Both SyncIn and SyncOut will allocate sufficient memory on the device. Signed-off-by: Joseph Schuchart <[email protected]>

Signed-off-by: Joseph Schuchart <[email protected]>

- TTG_HAVE_CUDA enables CUDA support: synchronizing the stream between the kernel call and the output call. - TTG_USE_CUDA_PREFETCH enables support for prefetching based on the view scope. Signed-off-by: Joseph Schuchart <[email protected]>

Signed-off-by: Joseph Schuchart <[email protected]>

…M and DM models

…ake outterm as an argument

…paration for suspendable tasks

…buntu runners

This reverts commit 7dfe4ea.

Signed-off-by: Joseph Schuchart <[email protected]>

… the key in the profiling info under the parsec driver

…fine a core mask, not a core id

Signed-off-by: Joseph Schuchart <[email protected]>

devreal · 2023-03-08T20:47:49Z

ttg/ttg/parsec/ttg.h

+        }
+        detail::ttg_devid[i] = -1;
+      }
+      detail::parsec_devid = new int[detail::nb_ttg_devices];


Mhh, this means we always have to call nb() to get a valid pointer, before we can call allocate().

Yes, I'm aware of that, that's why allocate() and free() (and other functions that rely on the conversion) always do check if( nb() >= ... ) as the first instruction before using detail::parsec_devid ... But maybe it's too circumvoluted...

There are alternatives... Let me know if you want to discuss this.

devreal · 2023-03-08T20:51:16Z

ttg/ttg/util/device.h

@@ -0,0 +1,13 @@
+#ifndef TTG_UTILS_DEVICE_H
+#define TTG_UTILS_DEVICE_H


This is not util functionality, but provided to the user. Should be one level up. I think we should put all device-related functions and objects into the ttg::device:: namespace.

Fine with me, I'll promote.

See e7fc769

Signed-off-by: Joseph Schuchart <[email protected]>

Refactor allocator API to be more object-oriented

Signed-off-by: Joseph Schuchart <[email protected]>

Refactor allocator API to be more object-oriented

devreal and others added 30 commits October 14, 2022 13:46

Mock of ttg::make_device_tt and views

a5c5ba7

Signed-off-by: Joseph Schuchart <[email protected]>

Add new header to CMake files

dad4a6c

Signed-off-by: Joseph Schuchart <[email protected]>

Add device_mock example to compile the ttg device mock API

977048d

Signed-off-by: Joseph Schuchart <[email protected]>

[example/device_mock] added missing #include

b86f1b0

[example/device_mock] declare as off-limits to clang-format

834f5f2

[example/device_mock] cleanup

cb9b74f

Partial implementation of ttg::make_device_tt

775a5db

Signed-off-by: Joseph Schuchart <[email protected]>

Merge branch 'master' into ttg-device-support-master

7d9ed91

# Conflicts: # examples/CMakeLists.txt

fixup span.h for when using c++20

aa77974

(cherry picked from commit 8147ac0)

make device_mock compile again, and no need for MAWworld for no reason

a24eadc

Encapsulate callables passed to make_device_tt mock in a regular task

5e49bd2

Signed-off-by: Joseph Schuchart <[email protected]>

Use the new multiindex key type in device mock example

efaa252

Signed-off-by: Joseph Schuchart <[email protected]>

Remove superfluous todos

ed01b32

The views on the device will be handled by the backend, not in ttg::make_view Signed-off-by: Joseph Schuchart <[email protected]>

Add missing view include in madness backend

9a6251b

Signed-off-by: Joseph Schuchart <[email protected]>

Rename CUDA precompile guards:

339f296

- TTG_HAVE_CUDA enables CUDA support: synchronizing the stream between the kernel call and the output call. - TTG_USE_CUDA_PREFETCH enables support for prefetching based on the view scope. Signed-off-by: Joseph Schuchart <[email protected]>

Remove noexcept from from default View ctor

2100f17

Signed-off-by: Joseph Schuchart <[email protected]>

Add missing terminal name in mock device example

8e6b6ff

Signed-off-by: Joseph Schuchart <[email protected]>

Add a fence to the mock device test to make the termdet happy

8d19b20

Signed-off-by: Joseph Schuchart <[email protected]>

Add iovec.h to list of installed files.

0fac7e5

Signed-off-by: Joseph Schuchart <[email protected]>

slight reorg of contrib dox + added device design notes

293fe68

updated device design notes to point out the need for Views in both U…

1fda791

…M and DM models

make TTG compilable with C++20

781c5f5

avoid infinite recursion in ttg::{set_size,finalize}<i> that do not t…

0b1f136

…ake outterm as an argument

ttg_parsec::TT::static_op{,_noarg} return parsec_hook_return_t in pre…

75a2fce

…paration for suspendable tasks

cleanup

ca4ab38

find <coroutine>

a5ae409

added an example of a task body being a (trivial) coroutine

0da8a01

[ci] try using gcc-10, first to provide support C++ corotuines, for u…

35277bc

…buntu runners

[ci] try dumping CMake{Output,Error}.log if cmake fails

9f6f581

devreal and others added 18 commits January 26, 2023 12:56

Revert "Switch to a Thomas' branch that is close to PaRSEC master"

c203dac

This reverts commit 7dfe4ea.

Some more device coroutine examples

987e98c

Signed-off-by: Joseph Schuchart <[email protected]>

Base of the beginning to log the appropriate info from the profiling

f3544fb

Update to appropriate version of parsec; use arrays of chars to store…

7ab4a1e

… the key in the profiling info under the parsec driver

Up to latest parsec version

ce71227

Update to latest parsec version

5cf5388

Porting over PaRSEC master: addto_nb_pa has been renamed and tasks de…

58603aa

…fine a core mask, not a core id

Point to the branch of PaRSEC master that has all needed features

a7388f4

Port deprecated types and functions to parsec master

6292ab5

Port the PaRSEC backend over a candidate PaRSEC master

6eaa97d

Use Thomas's github for the patched parsec branch

ce07798

Signed-off-by: Joseph Schuchart <[email protected]>

Make device coro tasks actually compile

62c1113

Signed-off-by: Joseph Schuchart <[email protected]>

Many fixes to coro-based device tasks

45183ce

Signed-off-by: Joseph Schuchart <[email protected]>

Clean up code from ttg::meta::is_detected debugging

a51b130

Clean up code from ttg::meta::is_detected debugging

9d3d975

Signed-off-by: Joseph Schuchart <[email protected]>

Implement ttg::buffer and ttg::devicescratch in the PaRSEC backend

522967a

Signed-off-by: Joseph Schuchart <[email protected]>

Support for moving between device and host tasks, much more

98a7a89

Signed-off-by: Joseph Schuchart <[email protected]>

get_ptr is not an awaitable operation

e07ebe5

Signed-off-by: Joseph Schuchart <[email protected]>

devreal requested changes Mar 8, 2023

View reviewed changes

devreal added 2 commits March 8, 2023 19:17

Extend CUDA test and add support for sending objects containing a buffer

2a0e47f

Fix msg header ctor and non-device tasks

de259c2

Signed-off-by: Joseph Schuchart <[email protected]>

therault force-pushed the ttg-device-support-master-coro branch from e7fc769 to 2a195f2 Compare March 15, 2023 17:21

Expose a backend allocator for the devices

7a08f07

Refactor allocator API to be more object-oriented

therault force-pushed the ttg-device-support-master-coro branch from 2a195f2 to 7a08f07 Compare March 15, 2023 17:23

devreal and others added 4 commits March 15, 2023 14:41

Draft for sending out of a device task

63b889c

Signed-off-by: Joseph Schuchart <[email protected]>

Expose a backend allocator for the devices

1bb638f

Refactor allocator API to be more object-oriented

conflict during merge

035406e

Fix conflict during pull

ab8184f

devreal force-pushed the ttg-device-support-master-coro branch from db6be87 to 91e13e8 Compare June 9, 2023 17:41

devreal force-pushed the ttg-device-support-master-coro branch from e0735a7 to 8362742 Compare July 6, 2023 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ttg device support master coro - util/device.h #5

Ttg device support master coro - util/device.h #5

therault commented Mar 8, 2023

devreal Mar 8, 2023

therault Mar 9, 2023

devreal Mar 8, 2023

therault Mar 9, 2023

therault Mar 9, 2023

		@@ -0,0 +1,13 @@
		#ifndef TTG_UTILS_DEVICE_H
		#define TTG_UTILS_DEVICE_H

Ttg device support master coro - util/device.h #5

Are you sure you want to change the base?

Ttg device support master coro - util/device.h #5

Conversation

therault commented Mar 8, 2023

devreal Mar 8, 2023

Choose a reason for hiding this comment

therault Mar 9, 2023

Choose a reason for hiding this comment

devreal Mar 8, 2023

Choose a reason for hiding this comment

therault Mar 9, 2023

Choose a reason for hiding this comment

therault Mar 9, 2023

Choose a reason for hiding this comment