Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP-RFC] Recipes #3

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[WIP-RFC] Recipes #3

wants to merge 9 commits into from

Conversation

georgebisbas
Copy link
Contributor

Several recipes that need to be reviewed so that they can be improved. Open for discussion.
The recipes are:

  1. gcc-mpich
  2. icc-mpich
  3. icc-intelmpi
    It is WIP

@georgebisbas georgebisbas self-assigned this Feb 12, 2020
mloubout
mloubout reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments

recipes/devito-icc-intelmpi/shipyard-config/jobs.yaml Outdated
I_MPI_PIN_DOMAIN: socket
I_MPI_DAPL_PROVIDER: ofa-v2-ib0
I_MPI_DYNAMIC_CONNECTION: 0
I_MPI_DAPL_TRANSLATION_CACHE: 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I seen and tried, most of these IMPI env variables are overwrtitten by batch-shipyard to match the supported version on the host.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, good to know.

recipes/devito-icc-mpich/docker/Dockerfile
./install.sh --silent=/tmp/icc-config.cfg --components intel-mpi-psxe__x86_64 && \
./install.sh --silent=/tmp/icc-config.cfg --components intel-icc__x86_64 && \
./install.sh --silent=/tmp/icc-config.cfg --components intel-mpi-sdk__x86_64 && \
./install.sh --silent=/tmp/icc-config.cfg --components intel-mpi-rt__x86_64 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you installing like that rather than just use the icc-config.cgfg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not using the duplicate in that. I will fix it

recipes/devito-icc-mpich/docker/Dockerfile Outdated

RUN ls opt/intel/compilers_and_libraries/linux/
RUN /bin/bash -c "source /opt/intel/compilers_and_libraries/linux/bin/compilervars.sh -arch intel64 -platform linux"
RUN /bin/bash -c "source /opt/intel/compilers_and_libraries/linux/mpi/intel64/bin/mpivars.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sh to bash at top

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure

recipes/devito-icc-mpich/docker/Dockerfile Outdated
RUN apt-get install -y python3 python3-pip
RUN pip3 install --upgrade pip
RUN git clone -b azure-make https://github.com/devitocodes/devito.git
RUN cd devito && pip3 install -e .[extras]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source intel

recipes/devito-icc-mpich/shipyard-config/jobs.yaml Outdated
OMP_PROC_BIND: 'close'
DEVITO_MPI: 1
DEVITO_OPENMP: 1
OMP_PLACES: 'cores'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's for gnu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

recipes/devito-icc-mpich/shipyard-config/jobs.yaml Outdated
environment_variables:
DEVITO_ARCH: intel
OMP_NUM_THREADS: 8
OMP_PROC_BIND: 'close'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's for gnu

recipes/devito-icc-mpich/shipyard-config/jobs.yaml Outdated
processes_per_node: 2
options:
- --bind-to socket
pre_execution_command: source /opt/intel/compilers_and_libraries/linux/bin/compilervars.sh -arch intel64 -platform linux; source /opt/intel/compilers_and_libraries/linux/mpi/intel64/bin/mpivars.sh; pip3 install mpi4py;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you sourcing intel mpi for mpich run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remianders

georgebisbas
georgebisbas commented Feb 12, 2020
View reviewed changes
Copy link
Contributor Author

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments, most of them where unused files. I am of the opinion that we can build a repo here where we populate with recipes that work. So we can easily have discussions and improvement. Thanks again for the help.

recipes/devito-icc-intelmpi/shipyard-config/jobs.yaml Outdated
I_MPI_PIN_DOMAIN: socket
I_MPI_DAPL_PROVIDER: ofa-v2-ib0
I_MPI_DYNAMIC_CONNECTION: 0
I_MPI_DAPL_TRANSLATION_CACHE: 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, good to know.

recipes/devito-icc-mpich/docker/Dockerfile
./install.sh --silent=/tmp/icc-config.cfg --components intel-mpi-psxe__x86_64 && \
./install.sh --silent=/tmp/icc-config.cfg --components intel-icc__x86_64 && \
./install.sh --silent=/tmp/icc-config.cfg --components intel-mpi-sdk__x86_64 && \
./install.sh --silent=/tmp/icc-config.cfg --components intel-mpi-rt__x86_64 && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not using the duplicate in that. I will fix it

recipes/devito-icc-mpich/docker/Dockerfile Outdated

RUN ls opt/intel/compilers_and_libraries/linux/
RUN /bin/bash -c "source /opt/intel/compilers_and_libraries/linux/bin/compilervars.sh -arch intel64 -platform linux"
RUN /bin/bash -c "source /opt/intel/compilers_and_libraries/linux/mpi/intel64/bin/mpivars.sh"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure

recipes/devito-icc-mpich/shipyard-config/jobs.yaml Outdated
OMP_PROC_BIND: 'close'
DEVITO_MPI: 1
DEVITO_OPENMP: 1
OMP_PLACES: 'cores'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

recipes/devito-icc-mpich/shipyard-config/jobs.yaml Outdated
processes_per_node: 2
options:
- --bind-to socket
pre_execution_command: source /opt/intel/compilers_and_libraries/linux/bin/compilervars.sh -arch intel64 -platform linux; source /opt/intel/compilers_and_libraries/linux/mpi/intel64/bin/mpivars.sh; pip3 install mpi4py;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remianders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloubout mloubout mloubout left review comments

Assignees

@georgebisbas georgebisbas

Labels
Azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgebisbas @mloubout