TMS-1032: Add seconds to countdown-timer block #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPiirainen
approved these changes
May 6, 2024
| @@ -61,11 +63,13 @@ export default class Countdown { | |||
| diff = targetTime - now, | |||
| days = Math.floor( diff / ( 1000 * 60 * 60 * 24 ) ), | |||
| hours = Math.floor( ( diff % ( 1000 * 60 * 60 * 24 ) ) / ( 1000 * 60 * 60 ) ), | |||
| minutes = Math.floor( ( diff % ( 1000 * 60 * 60 ) ) / ( 1000 * 60 ) ); | |||
| minutes = Math.floor( ( diff % ( 1000 * 60 * 60 ) ) / ( 1000 * 60 ) ), | |||
| seconds = Math.floor( ( diff % ( 1000 * 60 ) ) / 1000 ); | |||
There was a problem hiding this comment.
Näissä ois varmaan voinut käyttää näitä laskettuja arvoja hyödyksi, esim. days = Math.floor( ( diff % days ) / ( 1000 * 60 * 60 ) ) tjsp. Mutta ei tarvi nyt alkaa muuttamaan.
|
|
||
| @include from($tablet) { | ||
| &--seconds { | ||
| width: 125px; |
There was a problem hiding this comment.
Saisko laitettua remeinä?
| msgstr "" | ||
|
|
||
| #: assets/dist/vendor.js:1 | ||
| msgid "Wrong length!" |
There was a problem hiding this comment.
Nää vendor-filun käännökset kannattaisi jättää pois, mutta ei tarvi nyt muuttaa kun ei näitä kauheeta läjää tullut
lib/ACF/Fields/CountdownFields.php
Outdated
| 'countdown' => 'Laskuri (päivät, tunnit, minuutit)', | ||
| 'countdown_date' => 'Laskuri (päivät)', | ||
| 'date' => 'Päivämäärä', | ||
| 'countdown_seconds' => 'Laskuri (päivät, tunnit, minuutit, sekuntit)', |
There was a problem hiding this comment.
Suggested change
| 'countdown_seconds' => 'Laskuri (päivät, tunnit, minuutit, sekuntit)', | |
| 'countdown_seconds' => 'Laskuri (päivät, tunnit, minuutit, sekunnit)', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severa-ID: 2108
Severa-kuvaus: TMS-1032 Sekunnit näkyviin count down -laskuriin
Task: https://hiondigital.atlassian.net/browse/TMS-1032
Description
Types of changes