image meta formatting

devgeniem · Dec 14, 2021 · ff5dddb · ff5dddb
1 parent a3280f9
commit ff5dddb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/lib/Formatters/ImageFormatter.php b/lib/Formatters/ImageFormatter.php
@@ -95,20 +95,15 @@ public static function get_image_artist( array $row, array $image ) : array {
         $row['artist_name'] = trim( get_field( 'artist_name', $image_id ) );
         $row['image_title'] = trim( $image['title'] ?? '' );
 
-        if ( ! empty( $row['artist_name'] ) && ! empty( $row['image_title'] ) ) {
-            $row['image_title_and_artist'] = sprintf(
-                '%s: %s',
-                $row['artist_name'],
-                $row['image_title']
-            );
+        if ( ! empty( $row['artist_name'] ) ) {
+            $row['image_title_and_artist'] .= sprintf( '%s: ', $row['artist_name'] );
+        }
+        elseif ( ! empty( $row['author_name'] ) ) {
+            $row['image_title_and_artist'] .= sprintf( '%s: ', $row['author_name'] );
         }
 
-        if ( ! empty( $row['author_name'] ) && ! empty( $row['image_title'] ) ) {
-            $row['image_author_and_artist'] = sprintf(
-                '%s: %s',
-                $row['author_name'],
-                $row['image_title']
-            );
+        if ( ! empty( $row['image_title'] ) ) {
+            $row['image_title_and_artist'] .= sprintf( '%s.', $row['image_title'] );
         }
 
         return $row;

diff --git a/partials/ui/image/image-block__meta.dust b/partials/ui/image/image-block__meta.dust
@@ -1,7 +1,7 @@
 <div class="columns image-block__meta pt-2{?author_name} is-reversed{/author_name}">
     {?author_name}
         <div class="column is-2 has-text-right image-block__author-name has-text-small">
-            {author_name|s}
+            {author_name|s}.
         </div>
     {/author_name}
     {?caption}