Adds the ability to use a schema other than pg_temp for installing catalog functions. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,6 +141,8 @@ class PostgresSettings(BaseSettings): | |||
|
|
|||
| model_config = {"env_file": ".env", "extra": "ignore"} | |||
|
|
|||
| tipg_schema: str = Field("pg_temp", pattern=r"[a-zA-Z][a-zA-Z0-9_-]*") | |||
There was a problem hiding this comment.
- can you move this up, before the model_config
- what do you think about
TIPG_SCHEMA_NAME?
| @@ -61,10 +62,14 @@ async def __call__(self, conn: asyncpg.Connection): | |||
|
|
|||
| # Register custom SQL functions/table/views in pg_temp | |||
| for sqlfile in self.user_sql_files: | |||
| await conn.execute(sqlfile.read_text()) | |||
| await conn.execute( | |||
| sqlfile.read_text().replace("pg_temp", settings.tipg_schema) | |||
There was a problem hiding this comment.
I'm trying to think about the use case for the custom function to have access the the pg_temp schema?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the tipg_schema setting to PostgresSettings defaulting to "pg_temp" to allow installing tipg catalog functions into a permanent schema (NOTE: this schema must already exist, and the logged in user must have full permissions to the schema!).
Basically, this is just doing a replace of "pg_temp" in the dbcatalog.sql with whatever is set in the tipg_schema setting.