Skip to content

Commit

Permalink
Revert to use secrets since ODIC is not enabled for OSS (#878)
Browse files Browse the repository at this point in the history
  • Loading branch information
eljog authored Dec 7, 2023
1 parent 722d41d commit c2b4c10
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/push-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ on:
schedule:
- cron: '0 14 * * MON'

permissions:
id-token: write
contents: write
pull-requests: write

jobs:
build-and-push:
name: Build and push
Expand All @@ -20,7 +15,6 @@ jobs:
page-total: [66]
fail-fast: false
runs-on: devcontainer-image-builder-ubuntu
environment: documentation
steps:
- name: Free more space
id: free_space
Expand All @@ -39,9 +33,7 @@ jobs:
id: az_login
uses: azure/login@v1
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
creds: ${{ secrets.AZ_ACR_CREDS }}

- name: Build and push dev tags
id: build_and_push
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/version-history.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ jobs:
id: az_login
uses: azure/login@v1
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
creds: ${{ secrets.AZ_ACR_CREDS }}

- name: Get image info
id: Get_image_info
Expand Down

2 comments on commit c2b4c10

@Maskdownkey
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Maskdownkey
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.