Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow single-line comments #629

Closed
wants to merge 1 commit into from
Closed

Allow single-line comments #629

wants to merge 1 commit into from

Conversation

nwagner84
Copy link
Member

@nwagner84 nwagner84 commented Jun 21, 2023

Examples

$ cat filter.txt
041P{
    a == 'Algebra' && // Sachbegriff
    2 == 'lcsh'       // Code der Quelle
}

$ pica filter -f filter.txt "[email protected]?" tests/snapshot/data/algebra.dat | pica count --records
1
$ cat filter.txt
041P.a == 'Algebra' ||  // Sachbegriff
041P.2 == 'lcsh'       // Code der Quelle

$ pica filter -f filter.txt "[email protected]?" tests/snapshot/data/algebra.dat | pica count --records
1

Closes #457

@nwagner84 nwagner84 self-assigned this Jun 21, 2023
@nwagner84 nwagner84 changed the title Allow single-line comments WIP: Allow single-line comments Jun 21, 2023
@nwagner84 nwagner84 changed the title WIP: Allow single-line comments Allow single-line comments Jun 21, 2023
@nwagner84 nwagner84 marked this pull request as draft June 21, 2023 11:39
@nwagner84 nwagner84 closed this Sep 15, 2023
@nwagner84 nwagner84 deleted the matcher-comments branch September 15, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiline filter expression with comments
1 participant